i think this assign could have been better ,anyone willing to help?